From: Eric Bollengier <eric@baculasystems.com>
Date: Tue, 13 Sep 2022 07:52:00 +0000 (+0200)
Subject: Fix small memory leak when starting a job with PluginOptions
X-Git-Tag: Beta-15.0.0~447
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b24ae9a5b0c4975be7e5d8d92a0cd8bd19b710c4;p=thirdparty%2Fbacula.git

Fix small memory leak when starting a job with PluginOptions
---

diff --git a/bacula/src/dird/ua_run.c b/bacula/src/dird/ua_run.c
index 05467a3eb..3ce31335d 100644
--- a/bacula/src/dird/ua_run.c
+++ b/bacula/src/dird/ua_run.c
@@ -2567,7 +2567,7 @@ static bool scan_run_command_line_arguments(UAContext *ua, run_ctx &rc)
                   ua->send_msg(_("Plugin Options specified twice.\n"));
                   return false;
                }
-               rc.plugin_options = bstrdup(ua->argv[i]);
+               rc.plugin_options = ua->argv[i];
                if (!acl_access_ok(ua, PluginOptions_ACL, rc.plugin_options)) {
                   ua->send_msg(_("No authorization for \"PluginOptions\" specification.\n"));
                   return false;
@@ -2717,7 +2717,6 @@ static bool scan_run_command_line_arguments(UAContext *ua, run_ctx &rc)
       return false;
    }
 
-
    if (!get_client(ua, rc)) {
       return false;
    }
@@ -2737,7 +2736,7 @@ static bool scan_run_command_line_arguments(UAContext *ua, run_ctx &rc)
    }
 
    if (rc.job->JobType == JT_VERIFY && !rc.plugin_options && rc.job->PluginOptions) {
-      rc.plugin_options = bstrdup(rc.job->PluginOptions);
+      rc.plugin_options = rc.job->PluginOptions;
    }
 
    if (rc.previous_job_name) {