From: Travis Cross Date: Tue, 13 May 2014 17:36:15 +0000 (+0000) Subject: Avoid polluting CFLAGS for mod_snmp X-Git-Tag: v1.4.4~75 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b263201a2eb5020119f03527ef9e6fd7a14717ad;p=thirdparty%2Ffreeswitch.git Avoid polluting CFLAGS for mod_snmp Putting `net-snmp-config --cflags` into CFLAGS causes major pollution; it overrides optimization and debugging levels, warnings, and more. While normally we do want to automatically locate library headers, there has to be a better way to do this. libsnmp is normally in the usual place and doesn't need special handling. Perhaps people with libsnmp in a weird place should just need to add the -I flag to their CFLAGS before build. --- diff --git a/src/mod/event_handlers/mod_snmp/Makefile.am b/src/mod/event_handlers/mod_snmp/Makefile.am index b8cd61aaf2..e949e9ad9e 100644 --- a/src/mod/event_handlers/mod_snmp/Makefile.am +++ b/src/mod/event_handlers/mod_snmp/Makefile.am @@ -3,6 +3,6 @@ MODNAME=mod_snmp mod_LTLIBRARIES = mod_snmp.la mod_snmp_la_SOURCES = mod_snmp.c subagent.c -mod_snmp_la_CFLAGS = $(AM_CFLAGS) `net-snmp-config --cflags` +mod_snmp_la_CFLAGS = $(AM_CFLAGS) mod_snmp_la_LIBADD = $(switch_builddir)/libfreeswitch.la -lnetsnmpmibs -lnetsnmpagent -lnetsnmp mod_snmp_la_LDFLAGS = -avoid-version -module -no-undefined -shared