From: bugreport%peshkin.net <>
Date: Sat, 8 Oct 2005 11:58:54 +0000 (+0000)
Subject: Bug 28398 Gotta be more careful when emailing state changes of dependent bugs
X-Git-Tag: bugzilla-2.22rc1~242
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b26634d776066be7e6e358bfff0bad4a25a27d51;p=thirdparty%2Fbugzilla.git

Bug 28398 Gotta be more careful when emailing state changes of dependent bugs
Patch by André Batosti <batosti@async.com.br>
r=lpsolit, a=justdave
---

diff --git a/process_bug.cgi b/process_bug.cgi
index e98005a9cb..af3ebc9778 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -1914,9 +1914,9 @@ foreach my $id (@idlist) {
             $vars->{'id'} = $k;
             $vars->{'type'} = "dep";
 
-            # Let the user know we checked to see if we should email notice
-            # of this change to users with a relationship to the dependent
-            # bug and who did and didn't receive email about it.
+            # Let the user (if he is able to see the bug) know we checked to see 
+            # if we should email notice of this change to users with a relationship
+            # to the dependent bug and who did and didn't receive email about it.
             $template->process("bug/process/results.html.tmpl", $vars)
               || ThrowTemplateError($template->error());
             $vars->{'header_done'} = 1;
diff --git a/template/en/default/bug/process/bugmail.html.tmpl b/template/en/default/bug/process/bugmail.html.tmpl
index a2a6e7353e..a5d20e78dd 100644
--- a/template/en/default/bug/process/bugmail.html.tmpl
+++ b/template/en/default/bug/process/bugmail.html.tmpl
@@ -62,11 +62,15 @@
 
 [% BLOCK emails %]
   <b>[% description FILTER html %]:</b>
-  [% IF names.size > 0 %]
-    [%+ FOREACH name = names %]
-      [% name FILTER html %][% ", " UNLESS loop.last() %]
+  [% IF user.can_see_bug(mailing_bugid) %]
+    [% IF names.size > 0 %]
+      [%+ FOREACH name = names %]
+        [% name FILTER html %][% ", " UNLESS loop.last() %]
+      [% END %]
+    [% ELSE %]
+      no one
     [% END %]
   [% ELSE %]
-    no one
+    (list of e-mails not avaliable)
   [% END %]
 [% END %]