From: Martin Kletzander <mkletzan@redhat.com>
Date: Sat, 22 Apr 2017 16:34:30 +0000 (+0200)
Subject: Remove pointless check for !ret in virDomainNetDefCoalesceParseXML
X-Git-Tag: v3.3.0-rc1~107
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2763f189c5b306a685021b4fede9e2cee8528de;p=thirdparty%2Flibvirt.git

Remove pointless check for !ret in virDomainNetDefCoalesceParseXML

It was left there after removing a macro it was part of in first
version or so.  Now it will always be NULL.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4a777d67bf..7d3cf178ea 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6789,7 +6789,7 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node,
     if (!str)
         goto cleanup;
 
-    if (!ret && VIR_ALLOC(ret) < 0)
+    if (VIR_ALLOC(ret) < 0)
         goto cleanup;
 
     if (virStrToLong_ullp(str, NULL, 10, &tmp) < 0) {