From: Tim Duesterhus <tim@bastelstu.be>
Date: Sun, 23 Jun 2019 20:10:13 +0000 (+0200)
Subject: BUG/MINOR: spoe: Fix memory leak if failing to allocate memory
X-Git-Tag: v2.1-dev1~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b29861307253fcc25ed086eeb91f0723a24b282b;p=thirdparty%2Fhaproxy.git

BUG/MINOR: spoe: Fix memory leak if failing to allocate memory

Technically harmless, but it annoys clang analyzer.

This bug was introduced in 336d3ef0e77192582c98b3c578927a529ceadd9b.
This fix should be backported to HAProxy 1.9+.
---

diff --git a/src/flt_spoe.c b/src/flt_spoe.c
index f20b2640ba..4e48aa95c6 100644
--- a/src/flt_spoe.c
+++ b/src/flt_spoe.c
@@ -3751,6 +3751,7 @@ cfg_parse_spoe_agent(const char *file, int linenum, char **args, int kwm)
 				goto out;
 			}
 			if ((vph->name  = strdup(args[cur_arg])) == NULL) {
+				free(vph);
 				ha_alert("parsing [%s:%d] : out of memory.\n", file, linenum);
 				err_code |= ERR_ALERT | ERR_ABORT;
 				goto out;