From: Stephen Morris <stephen@isc.org>
Date: Thu, 12 Nov 2015 12:48:30 +0000 (+0000)
Subject: [master] Merge branch 'trac3259'
X-Git-Tag: trac4121_base~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2986b0b0299e691b13123922129bdbf8575afdb;p=thirdparty%2Fkea.git

[master] Merge branch 'trac3259'
---

b2986b0b0299e691b13123922129bdbf8575afdb
diff --cc doc/Makefile.am
index 5e31b591de,b98f1e3fb2..4fdea2ddae
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@@ -8,20 -8,20 +8,22 @@@ EXTRA_DIST += devel/qa.do
  
  EXTRA_DIST += images/isc-logo.png
  
- nobase_dist_doc_DATA  = examples/kea4/single-subnet.json
- nobase_dist_doc_DATA += examples/kea4/several-subnets.json
+ nobase_dist_doc_DATA  = examples/ddns/sample1.json
+ nobase_dist_doc_DATA += examples/ddns/template.json
+ nobase_dist_doc_DATA += examples/kea4/hooks.json
++nobase_dist_doc_DATA += examples/kea4/leases-expiration.json
  nobase_dist_doc_DATA += examples/kea4/multiple-options.json
  nobase_dist_doc_DATA += examples/kea4/reservations.json
- nobase_dist_doc_DATA += examples/kea4/leases-expiration.json
- nobase_dist_doc_DATA += examples/kea6/simple.json
- nobase_dist_doc_DATA += examples/kea6/several-subnets.json
- nobase_dist_doc_DATA += examples/kea6/multiple-options.json
+ nobase_dist_doc_DATA += examples/kea4/several-subnets.json
+ nobase_dist_doc_DATA += examples/kea4/single-subnet.json
  nobase_dist_doc_DATA += examples/kea6/advanced.json
- nobase_dist_doc_DATA += examples/kea6/stateless.json
- nobase_dist_doc_DATA += examples/kea6/reservations.json
+ nobase_dist_doc_DATA += examples/kea6/hooks.json
 +nobase_dist_doc_DATA += examples/kea6/leases-expiration.json
- nobase_dist_doc_DATA += examples/ddns/sample1.json
- nobase_dist_doc_DATA += examples/ddns/template.json
+ nobase_dist_doc_DATA += examples/kea6/multiple-options.json
+ nobase_dist_doc_DATA += examples/kea6/reservations.json
+ nobase_dist_doc_DATA += examples/kea6/several-subnets.json
+ nobase_dist_doc_DATA += examples/kea6/simple.json
+ nobase_dist_doc_DATA += examples/kea6/stateless.json
  
  devel:
  	mkdir -p html
diff --cc src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
index 1806f58269,008c32e539..39be6dd50e
--- a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
+++ b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
@@@ -913,33 -822,14 +913,32 @@@ TEST_F(ParseConfigTest, optionDataMinim
  
  }
  
 +// This test verifies an empty option data configuration is supported.
 +TEST_F(ParseConfigTest, emptyOptionData) {
 +    // Configuration string.
 +    const std::string config =
 +        "{ \"option-data\": [ {"
 +        "    \"name\": \"dhcp4o6-server-addr\""
 +        " } ]"
 +        "}";
 +
 +    int rcode = 0;
 +    ASSERT_NO_THROW(rcode = parseConfiguration(config));
 +    EXPECT_EQ(0, rcode);
 +    const Option6AddrLstPtr opt = boost::dynamic_pointer_cast<
 +        Option6AddrLst>(getOptionPtr("dhcp6", D6O_DHCPV4_O_DHCPV6_SERVER));
 +    ASSERT_TRUE(opt);
 +    ASSERT_EQ(0, opt->getAddresses().size());
 +}
 +
- };  // Anonymous namespace
- 
  /// The next set of tests check basic operation of the HooksLibrariesParser.
- 
- 
- // Utility function for setting up the "hooks-libraries" configuration.
  //
- // Returns a hooks-libraries configuration element that contains zero to
- // three libraries, depending on what arguments are supplied.
+ // Convenience function to set a configuration of zero or more hooks
+ // libraries:
+ //
+ // lib1 - No parameters
+ // lib2 - Empty parameters statement
+ // lib3 - Valid parameters
  std::string
  setHooksLibrariesConfig(const char* lib1 = NULL, const char* lib2 = NULL,
                          const char* lib3 = NULL) {
@@@ -2065,3 -2050,3 +2157,5 @@@ TEST_F(ParseConfigTest, validRelayInfo6
  // There's no test for ControlSocketParser, as it is tested in the DHCPv4 code
  // (see CtrlDhcpv4SrvTest.commandSocketBasic in
  // src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc).
++
++};  // Anonymous namespace