From: Thorsten Blum <thorsten.blum@linux.dev>
Date: Tue, 16 Dec 2025 14:52:37 +0000 (+0100)
Subject: dcache: Replace simple_strtoul with kstrtoul in set_dhash_entries
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b29a0a37f46bbfd2a36eff73eb66249d7baaf71a;p=thirdparty%2Flinux.git

dcache: Replace simple_strtoul with kstrtoul in set_dhash_entries

Replace simple_strtoul() with the recommended kstrtoul() for parsing the
'dhash_entries=' boot parameter.

Check the return value of kstrtoul() and reject invalid values. This
adds error handling while preserving behavior for existing values, and
removes use of the deprecated simple_strtoul() helper.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20251216145236.44520-2-thorsten.blum@linux.dev
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/dcache.c b/fs/dcache.c
index dc2fff4811d15..ec275f4fd81cd 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -3227,10 +3227,7 @@ EXPORT_SYMBOL(d_parent_ino);
 static __initdata unsigned long dhash_entries;
 static int __init set_dhash_entries(char *str)
 {
-	if (!str)
-		return 0;
-	dhash_entries = simple_strtoul(str, &str, 0);
-	return 1;
+	return kstrtoul(str, 0, &dhash_entries) == 0;
 }
 __setup("dhash_entries=", set_dhash_entries);