From: Mark Andrews <marka@isc.org>
Date: Sun, 7 Dec 2025 22:59:29 +0000 (+1100)
Subject: Missing unlock
X-Git-Tag: v9.21.17~55^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2a3a2ebcf08959f67bc5e033b087692fa61e1df;p=thirdparty%2Fbind9.git

Missing unlock

'kasp->lock' was not released before returning.
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 927c57e8093..1637af0e89f 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -22128,6 +22128,7 @@ isc_result_t
 dns_zone_dnssecstatus(dns_zone_t *zone, dns_kasp_t *kasp,
 		      dns_dnsseckeylist_t *keys, isc_stdtime_t now,
 		      bool verbose, char *out, size_t out_len) {
+	isc_result_t result;
 	isc_buffer_t buf;
 	isc_time_t refreshkeytime;
 	isc_stdtime_t refresh;
@@ -22152,10 +22153,10 @@ dns_zone_dnssecstatus(dns_zone_t *zone, dns_kasp_t *kasp,
 
 	bool checkds = zone->checkdstype != dns_checkdstype_no;
 	LOCK(&kasp->lock);
-	RETERR(dns_keymgr_status(kasp, keys, &buf, now, verbose, checkds));
+	result = dns_keymgr_status(kasp, keys, &buf, now, verbose, checkds);
 	UNLOCK(&kasp->lock);
 
-	return ISC_R_SUCCESS;
+	return result;
 }
 
 isc_result_t