From: Aaron Rainbolt Date: Thu, 14 Aug 2025 01:36:44 +0000 (-0500) Subject: include/xen/xen.h: Add warning comment for cmd_line X-Git-Tag: grub-2.14-rc1~117 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2a975bc5d516df1c3495d6d80878d65c3199114;p=thirdparty%2Fgrub.git include/xen/xen.h: Add warning comment for cmd_line The cmd_line field of the start_info struct is not guaranteed to be NUL-terminated, even though it is intended to contain a NUL-terminated string. Add a warning about this in a comment so future consumers of this field know to check it for a NUL terminator before using it. Signed-off-by: Aaron Rainbolt Reviewed-by: Daniel Kiper --- diff --git a/include/xen/xen.h b/include/xen/xen.h index fdf0fc448..4c21fb5ef 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -823,6 +823,11 @@ struct start_info { /* (PFN of pre-loaded module if */ /* SIF_MOD_START_PFN set in flags). */ unsigned long mod_len; /* Size (bytes) of pre-loaded module. */ + /* + * cmd_line will contain a NUL-termianted string if it contains valid + * data, but it MAY be invalid and not contain a NUL byte at all. Code + * that accesses cmd_line MUST NOT assume it is NUL-terminated. + */ #define GRUB_XEN_MAX_GUEST_CMDLINE 1024 int8_t cmd_line[GRUB_XEN_MAX_GUEST_CMDLINE]; /* The pfn range here covers both page table and p->m table frames. */