From: Mark Andrews <marka@isc.org>
Date: Fri, 10 Apr 2026 03:07:26 +0000 (+1000)
Subject: Remove unnecessary dns_name_free call
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2b248c8c01ca8f9e499c49453fcdfbbc1cff18f;p=thirdparty%2Fbind9.git

Remove unnecessary dns_name_free call

When processing a catalog zone member's primaries definition and
there is a TXT record containing an invalid name TSIG key name,
dns_name_free was incorrectly called triggering an assertion.
This has been fixed.

(cherry picked from commit 9f411c93c4d87b8097d39024da5a9da447cddaf7)
---

diff --git a/lib/dns/catz.c b/lib/dns/catz.c
index df101e32255..75eacc2c5dc 100644
--- a/lib/dns/catz.c
+++ b/lib/dns/catz.c
@@ -1133,7 +1133,6 @@ catz_process_masters(dns_catz_zone_t *zone, dns_ipkeylist_t *ipkl,
 			keycbuf[rdatastr.length] = 0;
 			result = dns_name_fromstring(keyname, keycbuf, 0, mctx);
 			if (result != ISC_R_SUCCESS) {
-				dns_name_free(keyname, mctx);
 				isc_mem_put(mctx, keyname, sizeof(dns_name_t));
 				return (result);
 			}