From: Jacob Potter <jacob@j4cbo.com>
Date: Wed, 31 Dec 2025 19:45:31 +0000 (-0500)
Subject: realtek: rtl838x: fix lan9 and lan10 on Netgear GS110TUP
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2c0182f26da795d70381ab0ebf6bdbc76cc8908;p=thirdparty%2Fopenwrt.git

realtek: rtl838x: fix lan9 and lan10 on Netgear GS110TUP

The GS110TUP's lan9 port is connected via a QSGMII PHY to SERDES 2, and
therefore should use the SWITCH_PORT_SDS macro instead of SWITCH_PORT. This
was missed in e956adfe because the GS110TUP is not particularly well
documented and the old code was confusing.

lan10 is an SFP and doesn't have an onboard PHY, so also remove its
associated PHY references and update it to match other devices' SFP ports.

Fixes: https://github.com/openwrt/openwrt/issues/21324
Signed-off-by: Jacob Potter <jacob@j4cbo.com>
Link: https://github.com/openwrt/openwrt/pull/21346
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---

diff --git a/target/linux/realtek/dts/rtl8380_netgear_gs110tup-v1.dts b/target/linux/realtek/dts/rtl8380_netgear_gs110tup-v1.dts
index b46aa57226b..f2f7afabbd6 100644
--- a/target/linux/realtek/dts/rtl8380_netgear_gs110tup-v1.dts
+++ b/target/linux/realtek/dts/rtl8380_netgear_gs110tup-v1.dts
@@ -47,24 +47,19 @@
 
 &mdio_bus0 {
 	EXTERNAL_PHY(16)
-	EXTERNAL_PHY(24)
 };
 
 &switch0 {
 	ports {
-		SWITCH_PORT(16, 9, qsgmii)
+		SWITCH_PORT_SDS(16, 9, 2, qsgmii)
 
-		/* TODO: fixed link SFP is not right */
-		port24: port@24 {
+		port@24 {
 			reg = <24>;
-			label = SWITCH_PORT_LABEL(10);
+			label = "lan10";
 			pcs-handle = <&serdes4>;
-			phy-handle = <&phy24>;
 			phy-mode = "1000base-x";
-			fixed-link {
-				speed = <1000>;
-				full-duplex;
-			};
+			managed = "in-band-status";
+			/* i2c and gpios not yet identified */
 		};
 	};
 };