From: Jeff Lucovsky <jeff@lucovsky.org>
Date: Fri, 10 Jul 2020 12:23:56 +0000 (-0400)
Subject: output/alert: Correct FORWARD_NULL Coverity issue.
X-Git-Tag: suricata-6.0.0-beta1~224
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2c1dab2da66ef44de120c9d9e5cce3e241ec422;p=thirdparty%2Fsuricata.git

output/alert: Correct FORWARD_NULL Coverity issue.

This commit corrects the FORWARD_NULL issue in AlertJson by
null-checking p->flow
---

diff --git a/src/output-json-alert.c b/src/output-json-alert.c
index c796aceee1..113070e6ac 100644
--- a/src/output-json-alert.c
+++ b/src/output-json-alert.c
@@ -563,7 +563,7 @@ static int AlertJson(ThreadVars *tv, JsonAlertLogThread *aft, const Packet *p)
         }
 
         /* including fileinfo data is configured by the metadata setting */
-        if (json_output_ctx->flags & LOG_JSON_RULE_METADATA) {
+        if (json_output_ctx->flags & LOG_JSON_RULE_METADATA && p->flow != NULL) {
             FileContainer *ffc = AppLayerParserGetFiles(p->flow,
                     p->flowflags & FLOW_PKT_TOSERVER ? STREAM_TOSERVER:STREAM_TOCLIENT);
             if (ffc != NULL) {