From: Eric Wong <e@80x24.org>
Date: Wed, 10 Jan 2024 11:18:53 +0000 (+0000)
Subject: net_reader: fix NNTP credential use
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2daac64423db99db12bd77afe4da813c26ee1b6;p=thirdparty%2Fpublic-inbox.git

net_reader: fix NNTP credential use

Clearly this was never tested until now, as passwords being
retrieved by git-credential got completely ignored and unused.
This enables users to connect to NNTP(S) servers requiring a
password.
---

diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index e3e5d596e..751043e9c 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -291,7 +291,10 @@ sub nn_for ($$$$) { # nn = Net::NNTP
 	return if $self->{quit};
 	$nn // die "E: <$uri> new: $@".onion_hint($lei, $uri);
 	if ($cred) {
-		$cred->fill($lei) unless defined($p); # may prompt user here
+		$p //= do {
+			$cred->fill($lei); # may prompt user here
+			$cred->{password};
+		};
 		if ($nn->authinfo($u, $p)) {
 			push @{$nntp_cfg->{-postconn}}, [ 'authinfo', $u, $p ];
 		} else {