From: Volker Lendecke <vl@samba.org>
Date: Fri, 24 Apr 2020 07:04:27 +0000 (+0200)
Subject: smbd: Make share_mode_memcache_fetch() use a const ptr
X-Git-Tag: ldb-2.2.0~735
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2dfd4cc5384d3eeb328bebe69de17b3aaa90040;p=thirdparty%2Fsamba.git

smbd: Make share_mode_memcache_fetch() use a const ptr

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c
index bbe22db10e5..e72b7215e50 100644
--- a/source3/locking/share_mode_lock.c
+++ b/source3/locking/share_mode_lock.c
@@ -285,9 +285,11 @@ static int share_mode_data_nofree_destructor(struct share_mode_data *d)
 	return -1;
 }
 
-static struct share_mode_data *share_mode_memcache_fetch(TALLOC_CTX *mem_ctx,
-					const TDB_DATA id_key,
-					DATA_BLOB *blob)
+static struct share_mode_data *share_mode_memcache_fetch(
+	TALLOC_CTX *mem_ctx,
+	const TDB_DATA id_key,
+	const uint8_t *buf,
+	size_t buflen)
 {
 	enum ndr_err_code ndr_err;
 	struct share_mode_data *d;
@@ -316,7 +318,7 @@ static struct share_mode_data *share_mode_memcache_fetch(TALLOC_CTX *mem_ctx,
 	}
 	/* sequence number key is at start of blob. */
 	ndr_err = get_share_mode_blob_header(
-		blob->data, blob->length, &sequence_number, &flags);
+		buf, buflen, &sequence_number, &flags);
 	if (ndr_err != NDR_ERR_SUCCESS) {
 		/* Bad blob. Remove entry. */
 		DBG_DEBUG("bad blob %u key %s\n",
@@ -383,7 +385,7 @@ static struct share_mode_data *parse_share_modes(TALLOC_CTX *mem_ctx,
 	blob.length = dbuf.dsize;
 
 	/* See if we already have a cached copy of this key. */
-	d = share_mode_memcache_fetch(mem_ctx, key, &blob);
+	d = share_mode_memcache_fetch(mem_ctx, key, dbuf.dptr, dbuf.dsize);
 	if (d != NULL) {
 		return d;
 	}