From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 5 Jan 2021 11:54:40 +0000 (+0100)
Subject: networkGetDHCPLeases: Don't assign @ipdef_tmp twice
X-Git-Tag: v7.0.0-rc1~114
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b304207f5865f00d99392b39afc0b9eb61d98dcd;p=thirdparty%2Flibvirt.git

networkGetDHCPLeases: Don't assign @ipdef_tmp twice

When rewriting the function, I've mistakenly declared a variable
and assigned it to itself. Let's initialize the variable properly.

Fixes: 5fb6d98c881c42ab41ca72060217b846949a438f
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 22d7d330a3..a7c5aade14 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -4155,7 +4155,7 @@ networkGetDHCPLeases(virNetworkPtr net,
 
             /* Obtain prefix */
             for (j = 0; j < def->nips; j++) {
-                virNetworkIPDefPtr ipdef_tmp = ipdef_tmp = &def->ips[j];
+                virNetworkIPDefPtr ipdef_tmp = &def->ips[j];
 
                 if (ipv6 && VIR_SOCKET_ADDR_IS_FAMILY(&ipdef_tmp->address,
                                                       AF_INET6)) {