From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Sat, 24 Sep 2022 00:25:10 +0000 (+1200)
Subject: s4:kdc: Don't copy data for empty PAC buffer
X-Git-Tag: talloc-2.4.0~745
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b32a3d715bcf1ffc8078eba06ebded02049251d6;p=thirdparty%2Fsamba.git

s4:kdc: Don't copy data for empty PAC buffer

Heimdal's 'data->length > 0' assertion in krb5_pac_add_buffer() is gone
as of f33f73f82fb2d5d96928ce5910e2d0d939c2ff57, so we no longer need to
specify a non-zero length.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 600ec6ac009..e77d163c075 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -521,7 +521,7 @@ krb5_error_code samba_make_krb5_pac(krb5_context context,
 	krb5_error_code ret;
 #ifdef SAMBA4_USES_HEIMDAL
 	char null_byte = '\0';
-	krb5_data null_data = smb_krb5_make_data(&null_byte, 1);
+	krb5_data null_data = smb_krb5_make_data(&null_byte, 0);
 #endif
 
 	/* The user account may be set not to want the PAC */