From: Daniel P. Berrange <berrange@redhat.com>
Date: Wed, 25 Sep 2013 14:37:10 +0000 (+0100)
Subject: Avoid use of uninitialized data in virnetmessagetest
X-Git-Tag: v1.1.3-rc1~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b32ac57ee5e0519283efa40f6196ba1fce2e753d;p=thirdparty%2Flibvirt.git

Avoid use of uninitialized data in virnetmessagetest

If an error occurs in virnetmessagetest it was possible it
would free uninitialized data.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c
index 3c9bead5d3..eabc609501 100644
--- a/tests/virnetmessagetest.c
+++ b/tests/virnetmessagetest.c
@@ -327,6 +327,8 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED)
     };
     int ret = -1;
 
+    memset(&err, 0, sizeof(err));
+
     if (!msg)
         return -1;
 
@@ -334,7 +336,6 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED)
     if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0)
         goto cleanup;
     memcpy(msg->buffer, input_buffer, msg->bufferLength);
-    memset(&err, 0, sizeof(err));
 
     if (virNetMessageDecodeLength(msg) < 0) {
         VIR_DEBUG("Failed to decode message header");