From: Peter Krempa Date: Thu, 6 Oct 2022 09:12:51 +0000 (+0200) Subject: conf: domain: Remove pointless XML node name validation in virSysinfoChassisParseXML X-Git-Tag: v8.10.0-rc1~210 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b349af14c596cf4b57cdd752743a87d60adedc11;p=thirdparty%2Flibvirt.git conf: domain: Remove pointless XML node name validation in virSysinfoChassisParseXML The only caller passes 'node' argument originating from an XPath lookup for the 'chassis' element, so there's no point in checking it once more. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 602ce8c0f3..f32eeaa94f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12271,12 +12271,6 @@ virSysinfoChassisParseXML(xmlNodePtr node, ctxt->node = node; - if (!xmlStrEqual(node->name, BAD_CAST "chassis")) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("XML does not contain expected 'chassis' element")); - return -1; - } - def->manufacturer = virXPathString("string(entry[@name='manufacturer'])", ctxt); def->version = virXPathString("string(entry[@name='version'])", ctxt); def->serial = virXPathString("string(entry[@name='serial'])", ctxt);