From: Terry Wilson <twilson@digium.com>
Date: Wed, 12 Jan 2011 21:05:02 +0000 (+0000)
Subject: Don't reject all SUBSCRIBE auth requests
X-Git-Tag: 1.6.2.17-rc1~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b381052ca065850e1e05168c391fef3146e205fa;p=thirdparty%2Fasterisk.git

Don't reject all SUBSCRIBE auth requests

When merging another SUBSCRIBE fix from 1.4, some braces were put in
the wrong place. This patch fixes that.

(closes issue #18597)
Reported by: thsgmbh



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@301682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index a65a5891ea..238421ecca 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -21532,10 +21532,10 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req,
 				ast_log(LOG_NOTICE, "Failed to authenticate device %s for SUBSCRIBE\n", get_header(req, "From"));
 				transmit_response_reliable(p, "403 Forbidden", req);
 			}
-		}
 
-		pvt_set_needdestroy(p, "authentication failed");
-		return 0;
+			pvt_set_needdestroy(p, "authentication failed");
+			return 0;
+		}
 	}
 
 	/* At this point, authpeer cannot be NULL. Remember we hold a reference,