From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 14 Jun 2024 08:07:02 +0000 (+0200)
Subject: vfs_recycle: use the correct return in SMB_VFS_HANDLE_GET_DATA()
X-Git-Tag: tdb-1.4.11~343
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b38241da3dd73386c4f41a56d95d33d4e1e3d2de;p=thirdparty%2Fsamba.git

vfs_recycle: use the correct return in SMB_VFS_HANDLE_GET_DATA()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15659

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Noel Power <noel.power@suse.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c
index 7f54cef4127..2293185a5af 100644
--- a/source3/modules/vfs_recycle.c
+++ b/source3/modules/vfs_recycle.c
@@ -436,14 +436,14 @@ static int recycle_unlink_internal(vfs_handle_struct *handle,
 	off_t file_size; /* space_avail;	*/
 	bool exist;
 	int rc = -1;
-	struct recycle_config_data *config;
+	struct recycle_config_data *config = NULL;
 
 	reload_services(NULL, NULL, false);
 
 	SMB_VFS_HANDLE_GET_DATA(handle,
 				config,
 				struct recycle_config_data,
-				return true);
+				return -1);
 
 	frame = talloc_stackframe();