From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Date: Tue, 29 Jul 2025 10:41:11 +0000 (+0200)
Subject: lxc/conf: do not leak opts.data memory in __lxc_idmapped_mounts_child()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b3a5d2814b3b25eb7d004fbb038bea3d8cf3e378;p=thirdparty%2Flxc.git

lxc/conf: do not leak opts.data memory in __lxc_idmapped_mounts_child()

Fixes: Coverity 1641425
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
---

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index 6c0e3d3c9..1899b2806 100644
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -2682,11 +2682,11 @@ static int __lxc_idmapped_mounts_child(struct lxc_handler *handler, FILE *f)
 		ret = parse_lxc_mount_attrs(&opts, mntent.mnt_opts);
 		if (ret < 0)
 			return syserror("Failed to parse LXC specific mount options");
-		__data = opts.data;
 
 		ret = parse_mount_attrs(&opts, mntent.mnt_opts);
 		if (ret < 0)
 			return syserror("Failed to parse mount options");
+		__data = opts.data;
 
 		/* No idmapped mount entry so skip it. */
 		if (is_empty_string(opts.userns_path))