From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Date: Thu, 17 Sep 2020 13:30:40 +0000 (-0400)
Subject: qemu: Block blockjobs when transient disk option is enabled
X-Git-Tag: v6.9.0-rc1~472
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b3c582623cf1041846cb4882c65b9a28f2bce2e8;p=thirdparty%2Flibvirt.git

qemu: Block blockjobs when transient disk option is enabled

For now we disallow blockjobs with transient disks to avoid dealing with
obsoleted overlays.

Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Tested-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index dc5949edfa..0331fd55e0 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -10859,6 +10859,13 @@ qemuDomainDiskBlockJobIsSupported(virDomainObjPtr vm,
         return false;
     }
 
+    if (disk->transient) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                       _("block jobs are not supported on transient disk '%s'"),
+                       disk->dst);
+        return false;
+    }
+
     return true;
 }