From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 6 Jan 2016 15:27:45 +0000 (+0100)
Subject: qemu: process: Disallow VMs with 0 vcpus
X-Git-Tag: v1.3.2-rc1~310
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b3c91b8a50ac0d772f883e737252202d48658139;p=thirdparty%2Flibvirt.git

qemu: process: Disallow VMs with 0 vcpus

Counterintuitively the user would end up with a VM with maximum number
of vCPUs available.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1290324
---

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 506979771f..97af3fa99f 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -3897,6 +3897,12 @@ qemuValidateCpuCount(virDomainDefPtr def,
 {
     unsigned int maxCpus = virQEMUCapsGetMachineMaxCpus(qemuCaps, def->os.machine);
 
+    if (virDomainDefGetVcpus(def) == 0) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                       _("Domain requires at least 1 vCPU"));
+        return -1;
+    }
+
     if (maxCpus > 0 && virDomainDefGetVcpusMax(def) > maxCpus) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Maximum CPUs greater than specified machine type limit"));