From: jonathan vanasco Date: Tue, 30 Jun 2020 16:31:58 +0000 (-0400) Subject: added semicolon (;) to improve warning message clarity X-Git-Tag: rel_1_4_0b1~238^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b421c51b94fdef2bc542b0a40bfb21490b23ca15;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git added semicolon (;) to improve warning message clarity ### Description Added a semicolon to improve the clarity of warning message. I actually had a table named `backend`, and thought it was involved! While updating the code, I noticed no test that directly tests for this warning message. There are tests for the `Can't sort tables for DROP;` prefix of this message and the `exc.CircularDependencyError`; and some tests for the `exc.CircularDependencyError` message itself. I couldn't find any test for this particular message though. (Just thought I'd bring that up) No issue created, because this is minor. Closes: #5431 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5431 Pull-request-sha: 87fb5733ff4fc1a13dd94277716814ea852f654c Change-Id: I87a504d30a7dd5155c34f7d7f30b2116d0d3cd3f --- diff --git a/lib/sqlalchemy/sql/ddl.py b/lib/sqlalchemy/sql/ddl.py index 17e3be2dac..3c23b50ca8 100644 --- a/lib/sqlalchemy/sql/ddl.py +++ b/lib/sqlalchemy/sql/ddl.py @@ -804,7 +804,7 @@ class SchemaDropper(DDLBase): util.warn( "Can't sort tables for DROP; an " "unresolvable foreign key " - "dependency exists between tables: %s, and backend does " + "dependency exists between tables: %s; and backend does " "not support ALTER. To restore at least a partial sort, " "apply use_alter=True to ForeignKey and " "ForeignKeyConstraint "