From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Sat, 9 Dec 2017 17:27:25 +0000 (+0100)
Subject: coverity: #1426029
X-Git-Tag: lxc-3.0.0.beta1~113^2~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b44c0a678797e965f731b3e2451d42c319e4a265;p=thirdparty%2Flxc.git

coverity: #1426029

fix use after free

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/storage/overlay.c b/src/lxc/storage/overlay.c
index ac7636192..6b93eb03b 100644
--- a/src/lxc/storage/overlay.c
+++ b/src/lxc/storage/overlay.c
@@ -207,8 +207,8 @@ int ovl_clonepaths(struct lxc_storage *orig, struct lxc_storage *new, const char
 
 		odelta = strchr(nsrc, ':');
 		if (!odelta) {
-			free(osrc);
 			ERROR("Failed to find \":\" in \"%s\"", nsrc);
+			free(osrc);
 			return -22;
 		}