From: Corey Farrell Date: Sun, 19 Nov 2017 01:50:48 +0000 (-0500) Subject: iostream: Fix ast_iostream_printf declaration. X-Git-Tag: 16.0.0-rc1~617^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b4862e463c9848edf1aea62b31852ace16523ad0;p=thirdparty%2Fasterisk.git iostream: Fix ast_iostream_printf declaration. This adds the printf attribute and changes 'fmt' from 'const void *' to 'const char *'. This resolves a warning from some compiler for vsnprintf needing a literal string for format. Change-Id: I71c33a8262590042ee451e1146760c10bb22fb78 --- diff --git a/include/asterisk/iostream.h b/include/asterisk/iostream.h index c641ffb373..e9816ac9b1 100644 --- a/include/asterisk/iostream.h +++ b/include/asterisk/iostream.h @@ -109,7 +109,8 @@ ssize_t ast_iostream_read(struct ast_iostream *stream, void *buf, size_t count); ssize_t ast_iostream_gets(struct ast_iostream *stream, char *buf, size_t count); ssize_t ast_iostream_discard(struct ast_iostream *stream, size_t count); ssize_t ast_iostream_write(struct ast_iostream *stream, const void *buf, size_t count); -ssize_t ast_iostream_printf(struct ast_iostream *stream, const void *fmt, ...); +ssize_t __attribute__((format(printf, 2, 3))) ast_iostream_printf( + struct ast_iostream *stream, const char *fmt, ...); struct ast_iostream* ast_iostream_from_fd(int *fd); int ast_iostream_start_tls(struct ast_iostream **stream, SSL_CTX *ctx, int client); diff --git a/main/iostream.c b/main/iostream.c index 2a2601d380..d91863319b 100644 --- a/main/iostream.c +++ b/main/iostream.c @@ -443,7 +443,7 @@ ssize_t ast_iostream_write(struct ast_iostream *stream, const void *buf, size_t } } -ssize_t ast_iostream_printf(struct ast_iostream *stream, const void *fmt, ...) +ssize_t ast_iostream_printf(struct ast_iostream *stream, const char *fmt, ...) { char sbuf[512], *buf = sbuf; int len, len2, ret = -1;