From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 6 Mar 2020 23:04:18 +0000 (-0600)
Subject: dhcpv6-decode: Don't need to use fr_pair_list_free when we're freeing a single vp
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b494cf523ff5e11f8134cfae3c7c1acabebef7fb;p=thirdparty%2Ffreeradius-server.git

dhcpv6-decode: Don't need to use fr_pair_list_free when we're freeing a single vp
---

diff --git a/src/protocols/dhcpv6/decode.c b/src/protocols/dhcpv6/decode.c
index c4295358c3d..b3c7fe28b3f 100644
--- a/src/protocols/dhcpv6/decode.c
+++ b/src/protocols/dhcpv6/decode.c
@@ -75,7 +75,7 @@ static ssize_t decode_raw(TALLOC_CTX *ctx, fr_cursor_t *cursor, UNUSED fr_dict_t
 	if (!vp) return -1;
 
 	if (fr_value_box_from_network(vp, &vp->data, vp->da->type, vp->da, data, data_len, true) < 0) {
-		fr_pair_list_free(&vp);
+		talloc_free(vp);
 		fr_dict_unknown_free(&da);
 		return -1;
 	}
@@ -193,7 +193,7 @@ static ssize_t decode_value(TALLOC_CTX *ctx, fr_cursor_t *cursor, fr_dict_t cons
 		if (!vp) return -1;
 
 		if (fr_value_box_from_network(vp, &vp->data, vp->da->type, vp->da, data, data_len, true) < 0) {
-			fr_pair_list_free(&vp);
+			talloc_free(vp);
 			goto raw;
 		}
 		break;
@@ -210,7 +210,7 @@ static ssize_t decode_value(TALLOC_CTX *ctx, fr_cursor_t *cursor, fr_dict_t cons
 		if (!vp) return -1;
 
 		if (fr_value_box_from_network(vp, &vp->data, vp->da->type, vp->da, data, data_len, true) < 0) {
-			fr_pair_list_free(&vp);
+			talloc_free(vp);
 			goto raw;
 		}
 		vp->vp_date += ((fr_time_t) DHCPV6_DATE_OFFSET) * NSEC;
@@ -389,7 +389,7 @@ static ssize_t decode_dns_labels(TALLOC_CTX *ctx, fr_cursor_t *cursor, fr_dict_t
 		 */
 		rcode = fr_dns_label_to_value_box(vp, &vp->data, data, data_len, data + total, true);
 		if (rcode <= 0) {
-			fr_pair_list_free(&vp);
+			talloc_free(vp);
 			goto raw;
 		}