From: Michael Brown <mcb30@etherboot.org>
Date: Thu, 16 Apr 2009 05:13:09 +0000 (+0100)
Subject: [build] Simplify use of Getopt::Long in padimg.pl
X-Git-Tag: v0.9.8~163
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b4a87daeb92453e5ae35e001bd0c477f41aea8a3;p=thirdparty%2Fipxe.git

[build] Simplify use of Getopt::Long in padimg.pl

Sometimes it's just so much fun doing things the complicated way that
you forget to check the man page for the existence of a simpler
syntax.
---

diff --git a/src/util/padimg.pl b/src/util/padimg.pl
index 71d0eee8a..4421aaf4b 100755
--- a/src/util/padimg.pl
+++ b/src/util/padimg.pl
@@ -9,16 +9,15 @@ my $verbosity = 0;
 my $blksize = 512;
 my $byte = 0;
 
-my $opts = {
+my %opts = (
   'verbose|v+' => sub { $verbosity++; },
   'quiet|q+' => sub { $verbosity--; },
   'blksize|s=o' => sub { $blksize = $_[1]; },
   'byte|b=o' => sub { $byte = $_[1]; },
-};
+);
 
 Getopt::Long::Configure ( 'bundling', 'auto_abbrev' );
-GetOptions ( { map { /^(\w+)/; $1 => $opts->{$_} } keys %$opts }, keys %$opts )
-    or die "Could not parse command-line options\n";
+GetOptions ( %opts ) or die "Could not parse command-line options\n";
 
 while ( my $filename = shift ) {
   die "$filename is not a file\n" unless -f $filename;