From: Al Viro Date: Tue, 27 Jan 2026 20:19:06 +0000 (-0500) Subject: tracefs: use d_splice_alias() in ->lookup() instances X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b4b559ac0526f5c09682735c1da78d297a4b79a7;p=thirdparty%2Fkernel%2Flinux.git tracefs: use d_splice_alias() in ->lookup() instances d_add() is not wrong there (inodes are freshly allocated), but d_splice_alias() is more idiomatic. Signed-off-by: Al Viro --- diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 26b6453de30ef..39c7a34531e8a 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -389,8 +389,7 @@ static struct dentry *lookup_file(struct eventfs_inode *parent_ei, // Files have their parent's ei as their fsdata dentry->d_fsdata = get_ei(parent_ei); - d_add(dentry, inode); - return NULL; + return d_splice_alias(inode, dentry); }; /** @@ -420,8 +419,7 @@ static struct dentry *lookup_dir_entry(struct dentry *dentry, dentry->d_fsdata = get_ei(ei); - d_add(dentry, inode); - return NULL; + return d_splice_alias(inode, dentry); } static inline struct eventfs_inode *init_ei(struct eventfs_inode *ei, const char *name)