From: Darren Tucker <dtucker@zip.com.au>
Date: Tue, 25 Oct 2016 21:43:25 +0000 (+1100)
Subject: Use !=NULL instead of >0 for getdefaultproj.
X-Git-Tag: V_7_4_P1~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b4e96b4c9bea4182846e4942ba2048e6d708ee54;p=thirdparty%2Fopenssh-portable.git

Use !=NULL instead of >0 for getdefaultproj.

getdefaultproj() returns a pointer so test it for NULL inequality
instead of >0.  Fixes compiler warning and is more correct.  Patch from
David Binderman.
---

diff --git a/openbsd-compat/port-solaris.c b/openbsd-compat/port-solaris.c
index bb8fccb41..0e89dc326 100644
--- a/openbsd-compat/port-solaris.c
+++ b/openbsd-compat/port-solaris.c
@@ -213,7 +213,7 @@ solaris_set_default_project(struct passwd *pw)
 
 	/* get default project, if we fail just return gracefully  */
 	if ((defaultproject = getdefaultproj(pw->pw_name, &tempproject, &buf,
-	    sizeof(buf))) > 0) {
+	    sizeof(buf))) != NULL) {
 		/* set default project */
 		if (setproject(defaultproject->pj_name, pw->pw_name,
 		    TASK_NORMAL) != 0)