From: Stefan Metzmacher Date: Wed, 5 Feb 2025 17:05:58 +0000 (+0100) Subject: s4:rpc_server/lsa: add allocation checks to fill_trust_domain_ex() X-Git-Tag: tevent-0.17.0~709 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b4e97c08bc0930f53bc4ec2c7552f73851f5f9c0;p=thirdparty%2Fsamba.git s4:rpc_server/lsa: add allocation checks to fill_trust_domain_ex() Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c index 4d9570aef4b..2acdb9b6fb6 100644 --- a/source4/rpc_server/lsa/dcesrv_lsa.c +++ b/source4/rpc_server/lsa/dcesrv_lsa.c @@ -2471,10 +2471,19 @@ static NTSTATUS fill_trust_domain_ex(TALLOC_CTX *mem_ctx, { info_ex->domain_name.string = ldb_msg_find_attr_as_string(msg, "trustPartner", NULL); + if (info_ex->domain_name.string == NULL) { + return NT_STATUS_TRUSTED_DOMAIN_FAILURE; + } info_ex->netbios_name.string = ldb_msg_find_attr_as_string(msg, "flatname", NULL); + if (info_ex->netbios_name.string == NULL) { + return NT_STATUS_TRUSTED_DOMAIN_FAILURE; + } info_ex->sid = samdb_result_dom_sid(mem_ctx, msg, "securityIdentifier"); + if (info_ex->sid == NULL) { + return NT_STATUS_NO_MEMORY; + } info_ex->trust_direction = ldb_msg_find_attr_as_int(msg, "trustDirection", 0); info_ex->trust_type