From: Johann-S <johann.servoire@gmail.com>
Date: Wed, 6 Feb 2019 13:35:59 +0000 (+0100)
Subject: fix modal test to be sure we call getTransitionDurationFromElement
X-Git-Tag: v4.3.0~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b54ddfda83bf1d8a01bc97e7636bdc4ae4af888a;p=thirdparty%2Fbootstrap.git

fix modal test to be sure we call getTransitionDurationFromElement
---

diff --git a/js/tests/unit/modal.js b/js/tests/unit/modal.js
index 1762904803..9b7fb0aa66 100644
--- a/js/tests/unit/modal.js
+++ b/js/tests/unit/modal.js
@@ -669,7 +669,7 @@ $(function () {
   })
 
   QUnit.test('transition duration should be the modal-dialog duration before triggering shown event', function (assert) {
-    assert.expect(2)
+    assert.expect(1)
     var done = assert.async()
     var style = [
       '<style>',
@@ -694,22 +694,17 @@ $(function () {
       '</div>'
     ].join('')
 
-    var beginTimestamp = 0
     var $modal = $(modalHTML).appendTo('#qunit-fixture')
-    var $modalDialog = $('.modal-dialog')
-    var transitionDuration  = Util.getTransitionDurationFromElement($modalDialog[0])
-
-    assert.strictEqual(transitionDuration, 300)
+    var expectedTransitionDuration = 300
+    var spy = sinon.spy(Util, 'getTransitionDurationFromElement')
 
     $modal.on('shown.bs.modal', function () {
-      var diff = Date.now() - beginTimestamp
-      assert.ok(diff < 400)
+      assert.ok(spy.returned(expectedTransitionDuration))
       $style.remove()
+      spy.restore()
       done()
     })
       .bootstrapModal('show')
-
-    beginTimestamp = Date.now()
   })
 
   QUnit.test('should dispose modal', function (assert) {