From: Andreas Schneider Date: Wed, 2 Nov 2016 16:19:09 +0000 (+0100) Subject: s3-winbind: Do not return NO_MEMORY if we have an empty user list X-Git-Tag: samba-4.4.9~32 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b55e69db07c3f82b8447f7a60994828c87ab037b;p=thirdparty%2Fsamba.git s3-winbind: Do not return NO_MEMORY if we have an empty user list The domain child for the MACHINE ACCOUNT might fail with NT_STATUS_NO_MEMORY because an emtpy user list is returned. *pnum_info is already set to 0 at the beginngin so we should just declare victory here! BUG: https://bugzilla.samba.org/show_bug.cgi?id=12405 Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison (cherry picked from commit e714dc03e0ccf9ec17da6bacc1bcfcaea7518e22) Autobuild-User(v4-4-test): Karolin Seeger Autobuild-Date(v4-4-test): Fri Nov 4 15:18:16 CET 2016 on sn-devel-144 --- diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c index 386396a1e19..7b355bafe91 100644 --- a/source3/winbindd/winbindd_rpc.c +++ b/source3/winbindd/winbindd_rpc.c @@ -88,6 +88,10 @@ NTSTATUS rpc_query_user_list(TALLOC_CTX *mem_ctx, num_dom_users = disp_info.info1.count; num_info += num_dom_users; + /* If there are no user to enumerate we're done */ + if (num_info == 0) { + return NT_STATUS_OK; + } info = talloc_realloc(mem_ctx, info,