From: Volker Lendecke Date: Tue, 9 Mar 2021 07:50:26 +0000 (+0100) Subject: srvsrvc: Reload conf after changing a share X-Git-Tag: tevent-0.11.0~1614 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5705cc70ce26c6ebd86abed15c0ffd8573bf84e;p=thirdparty%2Fsamba.git srvsrvc: Reload conf after changing a share The call to messaging_send_all() skips ourselves. This is tested in source3/script/tests/test_rpcclientsrvsvc.sh, which right now we only survive because the rpcclient call spawns a new smbd, which reloads smb.conf. Once you start running srvsvcd in a long-running daemon, this fails. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- diff --git a/source3/rpc_server/srvsvc/srv_srvsvc_nt.c b/source3/rpc_server/srvsvc/srv_srvsvc_nt.c index 474c0397ae6..8576e9d2ce2 100644 --- a/source3/rpc_server/srvsvc/srv_srvsvc_nt.c +++ b/source3/rpc_server/srvsvc/srv_srvsvc_nt.c @@ -1958,6 +1958,8 @@ WERROR _srvsvc_NetShareSetInfo(struct pipes_struct *p, ret = smbrun(command, NULL, NULL); if (ret == 0) { + reload_services(NULL, NULL, false); + /* Tell everyone we updated smb.conf. */ messaging_send_all(p->msg_ctx, MSG_SMB_CONF_UPDATED, NULL, 0);