From: Byron Jones <glob@mozilla.com>
Date: Wed, 28 May 2014 06:36:41 +0000 (+0800)
Subject: Bug 993939: Bugzilla::User::Setting::groups() should use memcached
X-Git-Tag: bugzilla-4.5.5~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5b5061ca90acd1e65fc5e2073dedf721117e553;p=thirdparty%2Fbugzilla.git

Bug 993939: Bugzilla::User::Setting::groups() should use memcached
---

diff --git a/Bugzilla/Memcached.pm b/Bugzilla/Memcached.pm
index 819b6d8b6b..1464b6c003 100644
--- a/Bugzilla/Memcached.pm
+++ b/Bugzilla/Memcached.pm
@@ -166,11 +166,11 @@ sub clear_all {
 
 sub clear_config {
     my ($self, $args) = @_;
+    return unless $self->{memcached};
     if ($args && exists $args->{key}) {
         $self->_delete($self->_config_prefix . '.' . $args->{key});
     }
     else {
-        return unless $self->{memcached};
         $self->_inc_prefix("config");
     }
 }
diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 6b5d13cbed..81ce228e70 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -668,8 +668,8 @@ sub flush_queries_cache {
 sub groups {
     my $self = shift;
 
-    return [] unless $self->id;
     return $self->{groups} if defined $self->{groups};
+    return [] unless $self->id;
 
     my $user_groups_key = "user_groups." . $self->id;
     my $groups = Bugzilla->memcached->get_config({