From: Florian Krohm <florian@eich-krohm.de>
Date: Sat, 2 Feb 2013 00:10:36 +0000 (+0000)
Subject: Shifting an int and assigning it to a long could be trouble.
X-Git-Tag: svn/VALGRIND_3_9_0^2~120
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5c1f8e3e73c26a7b0e479456f14e31ea1f0d977;p=thirdparty%2Fvalgrind.git

Shifting an int and assigning it to a long could be trouble.
It isn't here, but let's make the code clear in this respect.


git-svn-id: svn://svn.valgrind.org/vex/trunk@2674
---

diff --git a/VEX/priv/guest_ppc_toIR.c b/VEX/priv/guest_ppc_toIR.c
index f25e2487f6..f420bb5acf 100644
--- a/VEX/priv/guest_ppc_toIR.c
+++ b/VEX/priv/guest_ppc_toIR.c
@@ -2756,7 +2756,8 @@ static void putGST_field ( PPC_GST reg, IRExpr* src, UInt fld )
       shft = 4*(7-fld);
    else
       shft = 4*(15-fld);
-   mask = 0xF<<shft;
+   mask = 0xF;
+   mask = mask << shft;
 
    switch (reg) {
    case PPC_GST_CR: