From: kiko%async.com.br <>
Date: Thu, 29 Jul 2004 10:02:05 +0000 (+0000)
Subject: Missing bits of fix for bug 236678: Clean up access to COOKIE global.
X-Git-Tag: bugzilla-2.19.1~110
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5c21790186a08e0f03dc7f484a515ded65bc4d0;p=thirdparty%2Fbugzilla.git

Missing bits of fix for bug 236678: Clean up access to COOKIE global.
Murder the last remaining places in the tree where COOKIE is used;
includes a rather thorough cleanup of Bugzilla::Bug->user and a minor
doc update. r=joel, a=justdave.
---

diff --git a/Bugzilla/Auth/Login/WWW.pm b/Bugzilla/Auth/Login/WWW.pm
index 2c45562d26..d18c758d9a 100644
--- a/Bugzilla/Auth/Login/WWW.pm
+++ b/Bugzilla/Auth/Login/WWW.pm
@@ -43,9 +43,6 @@ sub login {
 
     # Avoid double-logins, which may confuse the auth code
     # (double cookies, odd compat code settings, etc)
-    # This is particularly important given the munging for
-    # $::COOKIE{'Bugzilla_login'} from a userid to a loginname
-    # (for backwards compat)
     if (defined $user) {
         return $user;
     }
@@ -71,11 +68,6 @@ sub login {
 
         # Compat stuff
         $::userid = $userid;
-
-        # Evil compat hack. The cookie stores the id now, not the name, but
-        # old code still looks at this to get the current user's email
-        # so it needs to be set.
-        $::COOKIE{'Bugzilla_login'} = $user->login;
     } else {
         Bugzilla->logout_request();
     }