From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 8 Nov 2024 11:11:47 +0000 (+0200)
Subject: config: Avoid panic if using auth settings inside local/remote filter
X-Git-Tag: 2.4.1~510
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5d9169247f472c18d32e4a09c0bdd35d69b8c6c;p=thirdparty%2Fdovecot%2Fcore.git

config: Avoid panic if using auth settings inside local/remote filter

Change it to a normal error instead.
---

diff --git a/src/config/config-parser.c b/src/config/config-parser.c
index 20640afbb9..24dad6dcec 100644
--- a/src/config/config-parser.c
+++ b/src/config/config-parser.c
@@ -1283,10 +1283,11 @@ config_filter_add_new_filter(struct config_parser_context *ctx,
 			i_assert(filter_info != NULL);
 			if (config_apply_line(ctx, filter_def->key,
 					      escaped_value, NULL) < 0) {
-				i_panic("BUG: Invalid setting definitions: "
+				ctx->error = p_strdup_printf(ctx->pool,
 					"Failed to set %s=%s for struct %s: %s",
 					filter_def->key, escaped_value,
 					filter_info->name, ctx->error);
+				return FALSE;
 			}
 		}
 		ctx->cur_section->filter_parser =