From: Mats Klepsland <mats.klepsland@gmail.com>
Date: Tue, 13 Nov 2018 19:06:50 +0000 (+0100)
Subject: app-layer-ssl: fix coverty error (RESOURCE_LEAK)
X-Git-Tag: suricata-4.1.1~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5dfc9ed412e13cd36f3fad9feb27f6e8537bdef;p=thirdparty%2Fsuricata.git

app-layer-ssl: fix coverty error (RESOURCE_LEAK)

Bug #2677
---

diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index a6219228dc..0aa3fab2d5 100644
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -1115,7 +1115,7 @@ static inline int TLSDecodeHSHelloExtensions(SSLState *ssl_state,
         ja3_elliptic_curves_pf = Ja3BufferInit();
         if (ja3_extensions == NULL || ja3_elliptic_curves == NULL ||
                 ja3_elliptic_curves_pf == NULL)
-            return -1;
+            goto error;
     }
 
     /* Extensions are optional (RFC5246 section 7.4.1.2) */