From: Yann Collet <yann.collet.73@gmail.com>
Date: Sun, 5 Jul 2015 07:20:56 +0000 (-0800)
Subject: Fixed a few minor visual analyzer warnings
X-Git-Tag: v0.1.0~3^2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5e06dc7c31070c30777843444e28078dfc9a9a2;p=thirdparty%2Fzstd.git

Fixed a few minor visual analyzer warnings
---

diff --git a/programs/datagen.c b/programs/datagen.c
index 9df9da841..50daaa077 100644
--- a/programs/datagen.c
+++ b/programs/datagen.c
@@ -56,7 +56,7 @@
 #if defined(MSDOS) || defined(OS2) || defined(WIN32) || defined(_WIN32) || defined(__CYGWIN__)
 #  include <fcntl.h>   /* _O_BINARY */
 #  include <io.h>      /* _setmode, _isatty */
-#  define SET_BINARY_MODE(file) _setmode(_fileno(file), _O_BINARY)
+#  define SET_BINARY_MODE(file) {int unused = _setmode(_fileno(file), _O_BINARY); (void)unused; }
 #else
 #  define SET_BINARY_MODE(file)
 #endif
diff --git a/programs/fileio.c b/programs/fileio.c
index 04d938fa4..ee23dc01c 100644
--- a/programs/fileio.c
+++ b/programs/fileio.c
@@ -65,7 +65,7 @@
 #  ifdef __MINGW32__
    /* int _fileno(FILE *stream);   // seems no longer useful // MINGW somehow forgets to include this windows declaration into <stdio.h> */
 #  endif
-#  define SET_BINARY_MODE(file) _setmode(_fileno(file), _O_BINARY)
+#  define SET_BINARY_MODE(file) { int unused = _setmode(_fileno(file), _O_BINARY); (void)unused; }
 #  define IS_CONSOLE(stdStream) _isatty(_fileno(stdStream))
 #else
 #  include <unistd.h>   /* isatty */
diff --git a/programs/fullbench.c b/programs/fullbench.c
index 11d9b62d1..b7ecc8db1 100644
--- a/programs/fullbench.c
+++ b/programs/fullbench.c
@@ -653,7 +653,7 @@ int main(int argc, char** argv)
         result = benchSample(benchNb);
     else result = benchFiles(argv+filenamesStart, argc-filenamesStart, benchNb);
 
-    if (main_pause) { printf("press enter...\n"); getchar(); }
+    if (main_pause) { int unused; printf("press enter...\n"); unused = getchar(); (void)unused; }
 
     return result;
 }
diff --git a/programs/fuzzer.c b/programs/fuzzer.c
index 8d48dcd2d..db4bc65fa 100644
--- a/programs/fuzzer.c
+++ b/programs/fuzzer.c
@@ -512,8 +512,10 @@ int main(int argc, char** argv)
         result = fuzzerTests(seed, nbTests, testNb, ((double)proba) / 100);
     if (mainPause)
     {
+        int unused;
         DISPLAY("Press Enter \n");
-        getchar();
+        unused = getchar();
+        (void)unused;
     }
     return result;
 }
diff --git a/programs/zstdcli.c b/programs/zstdcli.c
index e39266d45..7687218c4 100644
--- a/programs/zstdcli.c
+++ b/programs/zstdcli.c
@@ -150,8 +150,10 @@ static int badusage(const char* programName)
 
 static void waitEnter(void)
 {
+    int unused;
     DISPLAY("Press enter to continue...\n");
-    getchar();
+    unused = getchar();
+    (void)unused;
 }