From: Matthijs Mekking <matthijs@isc.org>
Date: Thu, 2 Apr 2026 09:20:32 +0000 (+0200)
Subject: Rename isdelegation() to is_insecure_referral()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b5f3e92fa75a0ceab3925da9fcbf769f121d8010;p=thirdparty%2Fbind9.git

Rename isdelegation() to is_insecure_referral()

The name 'isdelegation()' was confusing. This function is not checking
whether this message is a delegation, but whether the denial of
existence proofs in this message is a proof of a referral to an
unsigned zone.

The name 'is_unsecure_referral()' is more appropriate.

(cherry picked from commit e0f09bb3743015b405ae48c9664f46a422f546e2)
---

diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index d7d38df39a3..3ea4a640aec 100644
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -256,9 +256,9 @@ exit_check(dns_validator_t *val) {
 }
 
 /*%
- * The isdelegation() function is called as part of seeking the DS record.
- * Look in the NSEC or NSEC3 record returned from a DS query to see if the
- * record has the NS bitmap set. If so, we are at a delegation point.
+ * The is_insecure_referral() function is called as part of seeking the DS
+ * record. Look in the NSEC or NSEC3 record returned from a DS query to see if
+ * the record has the NS bitmap set. If so, we are at a delegation point.
  *
  * If the response contains NSEC3 records with too high iterations, we cannot
  * (or rather we are not going to) validate the insecurity proof. Instead we
@@ -273,8 +273,9 @@ exit_check(dns_validator_t *val) {
  *\li	#false the NS bitmap was not set.
  */
 static bool
-isdelegation(dns_validator_t *val, dns_name_t *name, dns_rdataset_t *rdataset,
-	     isc_result_t dbresult, const char *caller) {
+is_insecure_referral(dns_validator_t *val, dns_name_t *name,
+		     dns_rdataset_t *rdataset, isc_result_t dbresult,
+		     const char *caller) {
 	dns_fixedname_t fixed;
 	dns_label_t hashlabel;
 	dns_name_t nsec3name;
@@ -615,8 +616,9 @@ fetch_callback_ds(isc_task_t *task, isc_event_t *event) {
 		} else if (eresult == DNS_R_SERVFAIL) {
 			goto unexpected;
 		} else if (eresult != DNS_R_CNAME &&
-			   isdelegation(val, devent->foundname, &val->frdataset,
-					eresult, "fetch_callback_ds"))
+			   is_insecure_referral(val, devent->foundname,
+						&val->frdataset, eresult,
+						"fetch_callback_ds"))
 		{
 			/*
 			 * Failed to find a DS while trying to prove
@@ -784,8 +786,9 @@ validator_callback_ds(isc_task_t *task, isc_event_t *event) {
 		if ((val->attributes & VALATTR_INSECURITY) != 0 &&
 		    val->frdataset.covers == dns_rdatatype_ds &&
 		    NEGATIVE(&val->frdataset) &&
-		    isdelegation(val, name, &val->frdataset,
-				 DNS_R_NCACHENXRRSET, "validator_callback_ds"))
+		    is_insecure_referral(val, name, &val->frdataset,
+					 DNS_R_NCACHENXRRSET,
+					 "validator_callback_ds"))
 		{
 			result = markanswer(val, "validator_callback_ds",
 					    "no DS and this is a delegation");
@@ -2877,8 +2880,8 @@ seek_ds(dns_validator_t *val, isc_result_t *resp) {
 			return ISC_R_COMPLETE;
 		}
 
-		if (isdelegation(val, tname, &val->frdataset, result,
-				 "seek_ds"))
+		if (is_insecure_referral(val, tname, &val->frdataset, result,
+					 "seek_ds"))
 		{
 			*resp = markanswer(val, "seek_ds (3)",
 					   "this is a delegation");