From: justdave%syndicomm.com <>
Date: Thu, 21 Jun 2001 22:03:10 +0000 (+0000)
Subject: Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checks... 
X-Git-Tag: bugzilla-2.14~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6622d0c8e5c133e84b1738f94d318816319dbc6;p=thirdparty%2Fbugzilla.git

Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated.  Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
---

diff --git a/checksetup.pl b/checksetup.pl
index b349a30652..561d6fd4cd 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -1097,7 +1097,7 @@ AddFDef("component", "Component", 1);
 AddFDef("assigned_to", "AssignedTo", 1);
 AddFDef("reporter", "ReportedBy", 1);
 AddFDef("votes", "Votes", 0);
-AddFDef("qa_contact", "QAContact", 0);
+AddFDef("qa_contact", "QAContact", 1);
 AddFDef("cc", "CC", 1);
 AddFDef("dependson", "BugsThisDependsOn", 0);
 AddFDef("blocked", "OtherBugsDependingOnThis", 0);
diff --git a/doeditparams.cgi b/doeditparams.cgi
index 3d95637fe1..06019b8171 100755
--- a/doeditparams.cgi
+++ b/doeditparams.cgi
@@ -68,12 +68,6 @@ foreach my $i (@::param_list) {
 #      print "Old: '" . url_quote(Param($i)) . "'<BR>\n";
 #      print "New: '" . url_quote($::FORM{$i}) . "'<BR>\n";
         $::param{$i} = $::FORM{$i};
-        # If the useqacontact Param is changing, update the mailheader
-        if ($i eq 'useqacontact') {
-            print "&nbsp;&nbsp;&nbsp;- Updating mailhead information<br>\n";
-            SendSQL("UPDATE fielddefs SET mailhead = " . SqlQuote($::param{$i}) .
-                    "WHERE name = 'qa_contact'");
-        }
     }
 }