From: Han Han <hhan@redhat.com>
Date: Fri, 9 Aug 2019 06:29:41 +0000 (+0800)
Subject: libvirt-admin: Add missing API arguments in debug printings
X-Git-Tag: v5.7.0-rc1~299
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b67c1f3d02a8af2804f99f10b1b27f827d99f6f7;p=thirdparty%2Flibvirt.git

libvirt-admin: Add missing API arguments in debug printings

Each public API is required to log all arguments it was called
with. Except, there are some missing. Fix them.

Signed-off-by: Han Han <hhan@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c
index 4ae50b188f..e9ae765c5a 100644
--- a/src/libvirt-admin.c
+++ b/src/libvirt-admin.c
@@ -222,7 +222,7 @@ virAdmConnectOpen(const char *name, unsigned int flags)
     if (virAdmInitialize() < 0)
         goto error;
 
-    VIR_DEBUG("flags=0x%x", flags);
+    VIR_DEBUG("name=%s flags=0x%x", NULLSTR(name), flags);
     virResetLastError();
 
     if (!(conn = virAdmConnectNew()))
@@ -1034,7 +1034,8 @@ virAdmServerGetClientLimits(virAdmServerPtr srv,
 {
     int ret = -1;
 
-    VIR_DEBUG("srv=%p, flags=0x%x", srv, flags);
+    VIR_DEBUG("srv=%p, params=%p, nparams=%p, flags=0x%x",
+              srv, params, nparams, flags);
     virResetLastError();
 
     virCheckAdmServerGoto(srv, error);
@@ -1159,7 +1160,8 @@ virAdmConnectGetLoggingFilters(virAdmConnectPtr conn,
 {
     int ret = -1;
 
-    VIR_DEBUG("conn=%p, flags=0x%x", conn, flags);
+    VIR_DEBUG("conn=%p, filters=%p, flags=0x%x",
+              conn, filters, flags);
 
     virResetLastError();
     virCheckAdmConnectReturn(conn, -1);
@@ -1236,7 +1238,7 @@ virAdmConnectSetLoggingFilters(virAdmConnectPtr conn,
 {
     int ret = -1;
 
-    VIR_DEBUG("conn=%p, flags=0x%x", conn, flags);
+    VIR_DEBUG("conn=%p, filters=%s, flags=0x%x", conn, filters, flags);
 
     virResetLastError();
     virCheckAdmConnectReturn(conn, -1);