From: Denis Kirjanov <kirjanov@gmail.com>
Date: Wed, 28 Feb 2024 13:58:58 +0000 (-0500)
Subject: nstat: convert sprintf to snprintf
X-Git-Tag: v6.9.0~32^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b69e1e0445ab3cf2a90738317507a29a483c26b3;p=thirdparty%2Fiproute2.git

nstat: convert sprintf to snprintf

Use snprintf to print only valid data.
That's the similar change done for ifstat.

Signed-off-by: Denis Kirjanov <dkirjanov@suse.de>
Signed-off-by: David Ahern <dsahern@kernel.org>
---

diff --git a/misc/nstat.c b/misc/nstat.c
index ea96ccb0..7beb620b 100644
--- a/misc/nstat.c
+++ b/misc/nstat.c
@@ -483,7 +483,7 @@ static void server_loop(int fd)
 	p.fd = fd;
 	p.events = p.revents = POLLIN;
 
-	sprintf(info_source, "%d.%lu sampling_interval=%d time_const=%d",
+	snprintf(info_source, sizeof(info_source), "%d.%lu sampling_interval=%d time_const=%d",
 		getpid(), (unsigned long)random(), scan_interval/1000, time_constant/1000);
 
 	load_netstat();
@@ -636,7 +636,7 @@ int main(int argc, char *argv[])
 
 	sun.sun_family = AF_UNIX;
 	sun.sun_path[0] = 0;
-	sprintf(sun.sun_path+1, "nstat%d", getuid());
+	snprintf(sun.sun_path + 1, sizeof(sun.sun_path) - 1, "nstat%d", getuid());
 
 	if (scan_interval > 0) {
 		if (time_constant == 0)