From: dmachard <d.machard@gmail.com>
Date: Wed, 5 May 2021 16:51:50 +0000 (+0200)
Subject: change default timeout to 2s for lua records
X-Git-Tag: dnsdist-1.6.0~4^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b69ea3b5bc3b98222230774b85fb4a50d7c716a4;p=thirdparty%2Fpdns.git

change default timeout to 2s for lua records
---

diff --git a/docs/upgrading.rst b/docs/upgrading.rst
index 258d3f9d6d..9671625b5d 100644
--- a/docs/upgrading.rst
+++ b/docs/upgrading.rst
@@ -36,6 +36,11 @@ Their old names still work in 4.5.x, but will be removed in the release after it
 * :ref:`setting-slave` is now :ref:`setting-secondary`
 * :ref:`setting-superslave` is now :ref:`setting-autosecondary`
 
+Changed defaults
+~~~~~~~~~~~~~~~~
+
+- The default value of the ``timeout`` option for :ref:`ifportup` and :ref:`ifurlup` functions has been changed from ``1`` to ``2`` seconds.
+
 4.3.x to 4.4.0
 --------------
 
diff --git a/pdns/lua-record.cc b/pdns/lua-record.cc
index 31d4647ac2..a4e4eac11a 100644
--- a/pdns/lua-record.cc
+++ b/pdns/lua-record.cc
@@ -89,7 +89,7 @@ private:
   void checkURL(const CheckDesc& cd, const bool status, const bool first = false)
   {
     try {
-      int timeout = 1;
+      int timeout = 2;
       if (cd.opts.count("timeout")) {
         timeout = std::atoi(cd.opts.at("timeout").c_str());
       }
@@ -123,7 +123,7 @@ private:
   }
   void checkTCP(const CheckDesc& cd, const bool status, const bool first = false) {
     try {
-      int timeout = 1;
+      int timeout = 2;
       if (cd.opts.count("timeout")) {
         timeout = std::atoi(cd.opts.at("timeout").c_str());
       }