From: James Jones <jejones3141@gmail.com>
Date: Wed, 12 Jul 2023 13:13:04 +0000 (-0500)
Subject: Pull side effects out of TEST_CHECK() (CID #1538288)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6a94b3f79d417ae3f82cc7f74365a221cb506cb;p=thirdparty%2Ffreeradius-server.git

Pull side effects out of TEST_CHECK() (CID #1538288)
---

diff --git a/src/lib/util/edit_tests.c b/src/lib/util/edit_tests.c
index 29bfc58d7d9..d98a3c26011 100644
--- a/src/lib/util/edit_tests.c
+++ b/src/lib/util/edit_tests.c
@@ -86,15 +86,18 @@ static void add_pairs(fr_pair_list_t *local_pairs)
 
 	fr_pair_list_init(local_pairs);
 
-	TEST_CHECK((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32)) != NULL);
+	vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32);
+	TEST_CHECK(vp != NULL);
 	TEST_ASSERT(vp != NULL);
 	fr_pair_append(local_pairs, vp);
 
-	TEST_CHECK((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_octets)) != NULL);
+	vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_octets);
+	TEST_CHECK(vp != NULL);
 	TEST_ASSERT(vp != NULL);
 	fr_pair_append(local_pairs, vp);
 
-	TEST_CHECK((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv)) != NULL);
+	vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv);
+	TEST_CHECK(vp != NULL);
 	TEST_ASSERT(vp != NULL);
 	fr_pair_append(local_pairs, vp);