From: Ondřej Surý <ondrej@isc.org>
Date: Tue, 11 Oct 2022 07:10:16 +0000 (+0200)
Subject: Don't set load-balancing socket option on the UDP connect sockets
X-Git-Tag: v9.19.7~68^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6b7a6886a8ac66bc3932158740998a3bf2da014;p=thirdparty%2Fbind9.git

Don't set load-balancing socket option on the UDP connect sockets

The isc_nm_udpconnect() erroneously set the reuse port with
load-balancing on the outgoing connected UDP sockets.  This socket
option makes only sense for the listening sockets.  Don't set the
load-balancing reuse port option on the outgoing UDP sockets.
---

diff --git a/lib/isc/netmgr/udp.c b/lib/isc/netmgr/udp.c
index cd5513fc586..cda3d9d98ca 100644
--- a/lib/isc/netmgr/udp.c
+++ b/lib/isc/netmgr/udp.c
@@ -846,10 +846,6 @@ isc_nm_udpconnect(isc_nm_t *mgr, isc_sockaddr_t *local, isc_sockaddr_t *peer,
 	RUNTIME_CHECK(result == ISC_R_SUCCESS ||
 		      result == ISC_R_NOTIMPLEMENTED);
 
-	result = isc__nm_socket_reuse_lb(sock->fd);
-	RUNTIME_CHECK(result == ISC_R_SUCCESS ||
-		      result == ISC_R_NOTIMPLEMENTED);
-
 	(void)isc__nm_socket_incoming_cpu(sock->fd);
 
 	(void)isc__nm_socket_disable_pmtud(sock->fd, sa_family);