From: Vinit Agnihotri <vagnihot@redhat.com>
Date: Fri, 14 Nov 2025 06:00:20 +0000 (+0530)
Subject: printing: Fix coverity issue CID#1669074 (Unchecked return value)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6c1d0e5cee3217825676fb3fc03ef701152a93c;p=thirdparty%2Fsamba.git

printing: Fix coverity issue CID#1669074 (Unchecked return value)

A new coverity issue (Unchecked return value) is flagged as a regression
due to commit#e9a7dce599e.
This could have been present prior to comit#e9a7dce599e, however got missed.

This change fixes this issue by checking return value.

Signed-off-by: Vinit Agnihotri <vagnihot@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Mon Nov 17 08:31:24 UTC 2025 on atb-devel-224
---

diff --git a/source3/printing/printing.c b/source3/printing/printing.c
index 5fe9fcfcd5e..a9e8422efab 100644
--- a/source3/printing/printing.c
+++ b/source3/printing/printing.c
@@ -1051,12 +1051,18 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
 
 static void print_cache_flush(const char *sharename)
 {
+	int rc = 0;
 	struct tdb_print_db *pdb = get_print_db_byname(sharename);
 
 	if (!pdb)
 		return;
 
-	update_share_cache_time(CACHE_LAST_SCAN_TIME, sharename, pdb->tdb, -1);
+	rc = update_share_cache_time(CACHE_LAST_SCAN_TIME,
+				    sharename, pdb->tdb, -1);
+	if (rc != 0) {
+		DBG_ERR("Unable to reset last scan time for share:%s. rc=%d\n",
+			sharename, rc);
+	}
 	release_print_db(pdb);
 }