From: Joseph Sutton Date: Tue, 1 Aug 2023 22:04:23 +0000 (+1200) Subject: ndr_string: Move string length calculation fallback into default case X-Git-Tag: tevent-0.16.0~1177 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6c35d03c101ae822263a76e39cf1b016b415268;p=thirdparty%2Fsamba.git ndr_string: Move string length calculation fallback into default case We are about to add a new enumeration constant (NUM_CHARSETS) to charset_t. To do that we must have a default case in this switch statement, or the compiler will refuse to compile it, stating that we haven’t handled all the cases. The alternative, adding a case for NUM_CHARSETS, would just look silly. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/librpc/ndr/ndr_string.c b/librpc/ndr/ndr_string.c index 82cfe34e219..0a9d7ab8b9b 100644 --- a/librpc/ndr/ndr_string.c +++ b/librpc/ndr/ndr_string.c @@ -811,8 +811,8 @@ _PUBLIC_ uint32_t ndr_charset_length(const void *var, charset_t chset) case CH_DOS: case CH_UNIX: return strlen((const char *)var)+1; + default: + /* Fallback, this should never happen */ + return strlen((const char *)var)+1; } - - /* Fallback, this should never happen */ - return strlen((const char *)var)+1; }