From: Kurt Zeilenga <kurt@openldap.org>
Date: Sat, 11 Mar 2000 00:33:55 +0000 (+0000)
Subject: Import ITS#471 delete chasing fix from devel.
X-Git-Tag: OPENLDAP_REL_ENG_1_2_10~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6fb643d96f65646b9d97b8bcd8c5b6a3b5a76b4;p=thirdparty%2Fopenldap.git

Import ITS#471 delete chasing fix from devel.
---

diff --git a/CHANGES b/CHANGES
index 80f40d00bd..33e7474d04 100644
--- a/CHANGES
+++ b/CHANGES
@@ -8,6 +8,7 @@ Changes included in OpenLDAP 1.2.10 Release Engineering
 	Fixed -lldap Kerberos bind to work ldap_init() (ITS#426)
 	Changed -lldap to ignore space in filter: ( !(foo=bar)) (ITS#459)
 	Fixed multiple password support (ITS#464)
+	Fixed -lldap chasing of delete referrals (ITS#471)
 	Fixed back-ldbm/bind invalid credentials vs no such object bug 
 	Build Environment
 		Do not list unsupported LDBM API option NDBM
diff --git a/libraries/libldap/request.c b/libraries/libldap/request.c
index 33d7d67dc6..930ec49974 100644
--- a/libraries/libldap/request.c
+++ b/libraries/libldap/request.c
@@ -829,31 +829,33 @@ re_encode_request( LDAP *ld, BerElement *origber, int msgid, char **dnp )
 	tmpber = *origber;
 
 	/*
-	 * all LDAP requests are sequences that start with a message id,
-	 * followed by a sequence that is tagged with the operation code
+	 * all LDAP requests are sequences that start with a message id.
+	 * For all except delete, this is followed by a sequence that is
+	 * tagged with the operation code.  For delete, the provided DN
+	 * is not wrapped by a sequence.
 	 */
-	if ( ber_scanf( &tmpber, "{i", &along ) != LDAP_TAG_MSGID ||
-	    ( tag = ber_skip_tag( &tmpber, &along )) == LBER_DEFAULT ) {
-                ld->ld_errno = LDAP_DECODING_ERROR;
+	rc = ber_scanf( &tmpber, "{it", /*}*/ &along, &tag );
+
+	if ( rc == LBER_ERROR ) {
+		ld->ld_errno = LDAP_DECODING_ERROR;
 		return( NULL );
 	}
 
-        if (( ber = ldap_alloc_ber_with_options( ld )) == NULLBER ) {
-                return( NULL );
-        }
+	if ( tag == LDAP_REQ_BIND ) {
+		/* bind requests have a version number before the DN & other stuff */
+		rc = ber_scanf( &tmpber, "{ia" /*}*/, &ver, &orig_dn );
 
-	/* bind requests have a version number before the DN & other stuff */
-	if ( tag == LDAP_REQ_BIND && ber_get_int( &tmpber, (long *)&ver ) ==
-	    LBER_DEFAULT ) {
-                ld->ld_errno = LDAP_DECODING_ERROR;
-		ber_free( ber, 1 );
-		return( NULL );
+	} else if ( tag == LDAP_REQ_DELETE ) {
+		/* delete requests don't have a DN wrapping sequence */
+		rc = ber_scanf( &tmpber, "a", &orig_dn );
+
+	} else {
+		rc = ber_scanf( &tmpber, "{a" /*}*/, &orig_dn );
 	}
 
-	/* the rest of the request is the DN followed by other stuff */
-	if ( ber_get_stringa( &tmpber, &orig_dn ) == LBER_DEFAULT ) {
-		ber_free( ber, 1 );
-		return( NULL );
+	if( rc == LBER_ERROR ) {
+		ld->ld_errno = LDAP_DECODING_ERROR;
+		return NULL;
 	}
 
 	if ( *dnp == NULL ) {
@@ -862,20 +864,29 @@ re_encode_request( LDAP *ld, BerElement *origber, int msgid, char **dnp )
 		free( orig_dn );
 	}
 
+	if (( ber = ldap_alloc_ber_with_options( ld )) == NULL ) {
+		return( NULL );
+	}
+
 	if ( tag == LDAP_REQ_BIND ) {
-		rc = ber_printf( ber, "{it{is", msgid, tag, ver, *dnp );
+		rc = ber_printf( ber, "{it{is" /*}}*/, msgid, tag, ver, *dnp );
+	} else if ( tag == LDAP_REQ_DELETE ) {
+		rc = ber_printf( ber, "{its}", msgid, tag, *dnp );
 	} else {
 		rc = ber_printf( ber, "{it{s", msgid, tag, *dnp );
 	}
 
 	if ( rc == -1 ) {
+		ld->ld_errno = LDAP_ENCODING_ERROR;
 		ber_free( ber, 1 );
 		return( NULL );
 	}
 
-	if ( ber_write( ber, tmpber.ber_ptr, ( tmpber.ber_end -
-	    tmpber.ber_ptr ), 0 ) != ( tmpber.ber_end - tmpber.ber_ptr ) ||
-	    ber_printf( ber, "}}" ) == -1 ) {
+	if ( tag != LDAP_REQ_DELETE && (
+		ber_write(ber, tmpber.ber_ptr, ( tmpber.ber_end - tmpber.ber_ptr ), 0)
+		!= ( tmpber.ber_end - tmpber.ber_ptr ) ||
+	    ber_printf( ber, /*{{*/ "}}" ) == -1 ) )
+	{
 		ld->ld_errno = LDAP_ENCODING_ERROR;
 		ber_free( ber, 1 );
 		return( NULL );